Album missing in library view

[baldydonald]

curiosity got the better of me - I noticed that in "scripts-library.js" there are various places where LIB.filters.artists make use of the canonical (lowercase) form such as in filterByArtist(), but there are a few places where its a plain lookup - in the click handler for "albumsList" all of the manipulation of the LIB.filters.artists is arbitrary so may yield silent matching failures/misses in the event of tags being set inconsistently on audio files from the same album as has happened to me (I was using Apple's Music app to rip CDs).

For example, c. L1044 does a plain

Code:

   if (alreadyActive && LIB.filters.artists.length && !LIB.filters.artists.includes(albumobj.album_artist)) {

and the filing code for the filter also uses arbitrary form (c. L1045-1056):

Code:

                var n = LIB.filters.artists.length;
                albumArtists.forEach(artist => (!LIB.filters.artists.includes(artist) && LIB.filters.artists.push(artist)));
                filterSongs();

and c. L1097-1100):

Code:

                LIB.filters.artists.push(albumobj.album_artist);
                filterSongs();
                LIB.filters.artists.pop();
                renderSongs()

Its less clear to me whether this is actually a problem so I'm reluctant to propose any code changes, but thought it useful to highlight.