[PROBLEM] Library update in progress message

[TheOldPresbyope]

@Tim Curtis
Couldn't it be helpful to have (e.album_artist || e.artist || "missing tags") solve the issue for those "poorly tagged files"? As IMHO both tags are missing, resulting in undefined.toLowerCase() which of course does not exists...

Good point.

[the_bertrum]

OT but...
How come this thread is "important"?

[Nutul]

@the_bertrum
maybe because from time time there is somebody having some issues with it...
It should not be important... but having it highlighted (or, better, highlit?!?) may help people try to fix things BEFORE posting the same-old-story, and then you know what... ;-)

[Tim Curtis]

@Tim Curtis
Couldn't it be helpful to have (e.album_artist || e.artist || "missing tags") solve the issue for those "poorly tagged files"? As IMHO both tags are missing, resulting in undefined.toLowerCase() which of course does not exist...

Probably, but just displaying "missing tags" without identifying the file and logging it during Library update would not be helpful. Could be a good project for an interested dev but its not a trivial effort.

In any case over the years I've added code to handle certain file or tag issues but decided that its not worth adding a lot of extra code if the basic tags like Artist, Album, Title are missing. After all this isn't the 90's where tagging was done by embedding in the file names and directory structure :-0

IIRC players like Foobar are coded to better handle this type of collection.

ETA: Also, another good project for an interested dev would be to write a collection scanner that identified problematic tracks. It's not a trivial effort of course but it would a very useful utility. I suppose it raises the question of whether utilities already exist to scan collections. Surely they must.

[TheOldPresbyope]

Early in my moOde usage I thought I should put together such a utility, either a BASH or Python script. IIRC, I was inspired by the nearly two-decade old MP3 Diags effort. Once I started charting how many different file types and metadata coding schemes existed and trying to decide what errors I wanted to flag, I decided instead to open a bottle of wine and sip a glass or two in the sunroom while I let the notion pass.

Most existing programs assist in tagging files, not in analyzing files already tagged. Some can cause (more) damage in the process. An example is Mp3Tag, which is masterful but which can, for example, easily add ID3 tags to a FLAC file if the user doesn't mind the default settings. The resulting file is illegal, of course.

Anyway, @Nutul's observation has inspired me to test some modifications of the code in question. First have to create some music files known to trigger the fail to test with.

Regards,
Kent

[Yawarakaimono]

Isn't it possible to do a check on the PHP side if an update process really is running?
I play the music to listen to, thumbnails etc are nice but I don't care if they are missing.
Not being able to add new files because of missing metadata in some random individual file that has nothing to do with the new ones is a bit incomprehensible to me.
The new files are probably in an existing folder, so the operation 'update' is on directory level, again nothing to to with the metadata?
Isn't it MPD that needs the metadata to add to the database?

My guess is that the condition of currently playing / last played track decides if GLOBAL.libLoading and GLOBAL.libRendered exist and what their value is. So blocks a missing thumbnail the updating of a folder in the library.

[Tim Curtis]

Isn't it possible to do a check on the PHP side if an update process really is running?
I play the music to listen to, thumbnails etc are nice but I don't care if they are missing.
Not being able to add new files because of missing metadata in some random individual file that has nothing to do with the new ones is a bit incomprehensible to me.
The new files are probably in an existing folder, so the operation 'update' is on directory level, again nothing to to with the metadata?
Isn't it MPD that needs the metadata to add to the database?

Sure, MPD adds files with no tags to its database but moOde is designed around metadata tags because most users want to interact and navigate an organized Music Library as opposed to a file system. Missing critical tags like Artist and Album Artist are prolly going to cause issues but I already explained in a previous post why untagged files are not really high on my TODO list.

But if you are a developer you could consider contributing to the project and propose code that allows moOde to better support your particular collection, usage scenario, missing tags etc. I can prolly help out a bit.

[Yawarakaimono]

I don't ask for new functionality, I am a happy user of the folders view.
Every now and then a new digital album is added to my collection. Regenerating the database costs a few hours. Updating a folder demands less of my patience. But that is not possible any more because of the eternal update process that seems to be running. Even if I only connect the set of DSD files that I converted from my SACD disks.

[the_bertrum]

I'm pretty sure MP3tag has a "folders to tag" option but I don't have it installed anywhere so I can't check. There is also the non-free https://www.blisshq.com/ which automates retagging libraries in bulk based on rules you supply so you remain in control.

[Tim Curtis]

I don't ask for new functionality, I am a happy user of the folders view.
Every now and then a new digital album is added to my collection. Regenerating the database costs a few hours. Updating a folder demands less of my patience. But that is not possible any more because of the eternal update process that seems to be running. Even if I only connect the set of DSD files that I converted from my SACD disks.

Right but this is just more of the "going around in circles" talk. The issue has already been described. Whats needed is concrete debugging from your affected system that can help determine whats going on.

So far @alexarz reported a Javascript error in the console which aborts the script causing the GLOBAL.libLoading flag to remain true. The error apparently is caused by a file with no Artist or Album Artist tag.

You never replied to my earlier post whether there are any errors in your Browser console.
https://moodeaudio.org/forum/showthread....5#pid64715