[SOLVED] "HD" shown instead of "DSD128"

[ils1974]

* moOde 9.3.0
* Tested with FF and Chrome browsers

Issue: When I play the same DSD128 file from my NAS, depending on the way of operation, sometimes it displays "HD", sometimes "DSD128", while it has to be DSD128

How to reproduce?
Test 1
1) From within the Album view, select a DSD128 album, and via "..." do "Clear/Play". You'll see at the bottom the album starts playing and mentions "HD" (although it should be "DSD128")
2) Open another tab on your browser. the moOde tab jumps to the new opened tab.
3) Go back to the moOde tab.
4) "HD" will be updated to "DSD128"

Test 2
1) From within the Album view, select a DSD128 album, and via "..." do "Clear/Play". You'll see at the bottom the album starts playing and mentions "HD" (although it should be "DSD128")
2) At the bottom left, hit the "pause" buttton.
3) Stream stops playing and "HD" will be updated to "DSD128".

Test 3
1) Clear Q
2) From within the Album view, select a DSD128 album and via "..." do "Add".
3) After the items are added, hit the "play" button at the bottom left, and it starts playing, mentioning "DSD128", which is correct.

Test 4
1) Clear Q
2) From within the Album view, add a non DSD track (or album) to the Q
3) From within the Album view, select a DSD128 album and via "..." do "Add".
4) After the items are added, hit the "play" button at the bottom left.
5) When the first DSD track is played after the (last) non DSD track was played, it mentions "DSD128", which is correct.

[Tim Curtis]

I'll investigate

[ils1974]

Thank you!

[Tim Curtis]

I can repro that issue and its being caused by the method used to submit groups of MPD commands.

Here's some debug of a clear/play

Code:

20250409 065325 Array
(
   [0] => clear
   [1] => add "NAS/TRX-FLAC/The Police/Every Breath You Take - The Classics/01 Roxanne.dsf"
   [2] => play
)

The current method wraps this group of commands in MPD command_list statements like below and then submits to MPD. For some reason though the status info returned by MPD about the track being played is incomplete and thus the audio format information displayed in the WebUI may not be accurate.

Code:

command_list_begin
clear
add "NAS/TRX-FLAC/The Police/Every Breath You Take - The Classics/01 Roxanne.dsf"
play
command_list_end

When I test without the command_list wrapper and also fetch the response after each individual command is submitted all seems to be well again and the status info is complete.

More testing needs but this fix looks promising.

[ils1974]

Great you could diagnose it.
What is strange, is when you jump to another tab in the browser, and comeback to the moOde tab, the moOde GUI than updates to "DSD128". Looks like the page refresh is part of the story? This is Test case 1.

[Tim Curtis]

Yes, a page refresh will result in a fetch of MPD status info among other things.

[ils1974]

Fixed in 9.3.2. Thank you @Tim Curtis !

[ils1974]

Problem is back in 9.3.4

[Tim Curtis]

Not surprising.

The fix (removing the transaction wrappers)
https://github.com/moode-player/moode/co...dcf6117743

Caused other other issues when adding groups of tracks (album, artist or genre) and so it had to be reverted
https://github.com/moode-player/moode/co...8e4cdc3a9e

I'll look into it again and see whether there is another approach that might work.

[ils1974]

thank you!